Mason Malone

Results 66 comments of Mason Malone

@Joibel Yes, that sounds reasonable. I entered a draft PR for this: https://github.com/argoproj/argo-workflows/pull/15003

@dmarquez-splunk Good job tracking this down! I entered https://github.com/argoproj/argo-workflows/pull/15168 to upgrade `expr` to a version with the fix, and included a test case.

FYI: @bradfordwagner entered https://github.com/argoproj/argo-workflows/pull/14989 to only add support for the `root CA` option. I confirmed it's possible to test that in the local development environment: https://github.com/argoproj/argo-workflows/pull/14989#pullrequestreview-3386387456

Good start! A couple initial comments: 1. This project uses the [history](https://github.com/remix-run/history/) library, so I think (but I'm not sure) the `useEffect()` hooks need to incorporate it as a dependency....

@sairam91 Sorry for the delay. You mentioned you were going to fill out the "Verification" section of the PR, so I was waiting for that. If you're unsure of what...