M13PDFKit icon indicating copy to clipboard operation
M13PDFKit copied to clipboard

Toolbar missing

Open saran-metron opened this issue 8 years ago • 14 comments

hi,

i have enable all the toolbars but i am not getting any of them.can you please help me..what i am doing wrong.
    self.viewer.enableBookmarks = true
    self.viewer.enableOpening = true
    self.viewer.enablePreview = true
    self.viewer.enablePrinting =  true
    self.viewer.enableSharing = true
    self.viewer.standalone = false

with regards Saran screenshot

saran-metron avatar May 27 '16 14:05 saran-metron

I'm having the same problem, do we have to add the vfr/Reader classes for this to work?

dougdss avatar Jun 17 '16 19:06 dougdss

Still having this problem, what do we have wrong ??

EnesKaraosman avatar Aug 15 '16 05:08 EnesKaraosman

Use the vfr/Reader - https://github.com/vfr/Reader. Worked very good, Only need to copy the classes to the project and import.

dougdss avatar Aug 15 '16 14:08 dougdss

Works the same way then right ?

15 Ağustos 2016 Pazartesi tarihinde, Douglas Santos < [email protected]> yazdı:

Use the vfr/Reader - https://github.com/vfr/Reader. Worked very good, Only need to copy the classes to the project and import.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Marxon13/M13PDFKit/issues/25#issuecomment-239815744, or mute the thread https://github.com/notifications/unsubscribe-auth/AP5BN-I4-cCpP8uo0ZIFYeR7NBEubcuFks5qgHc_gaJpZM4Ioh5Z .

EnesKaraosman avatar Aug 15 '16 14:08 EnesKaraosman

Yes. but the toolbar works fine with these classes. You do not need to use cocoa pods, only download the project and copy the classes listed in the repository documentation.

dougdss avatar Aug 15 '16 14:08 dougdss

Do I have to use it with bridging with objective c.., or just like swift?

15 Ağustos 2016 Pazartesi tarihinde, Douglas Santos < [email protected]> yazdı:

Use the vfr/Reader - https://github.com/vfr/Reader. Worked very good, Only need to copy the classes to the project and import.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Marxon13/M13PDFKit/issues/25#issuecomment-239815744, or mute the thread https://github.com/notifications/unsubscribe-auth/AP5BN-I4-cCpP8uo0ZIFYeR7NBEubcuFks5qgHc_gaJpZM4Ioh5Z .

EnesKaraosman avatar Aug 15 '16 14:08 EnesKaraosman

if your project is in 'swift', you will need to use the bridging-header.

dougdss avatar Aug 15 '16 14:08 dougdss

Just grab the toolbar image to your Assets, then the toolbars should come..

EnesKaraosman avatar Aug 31 '16 11:08 EnesKaraosman

Yes. I've forgot to mention the images part.

dougdss avatar Sep 01 '16 21:09 dougdss

some times the toolbar images may be missed.. i used cocoapods ..it is working fine..if you are using pod please update pod and check

with regards Saran N.V

On Fri, Sep 2, 2016 at 2:56 AM, Douglas Santos [email protected] wrote:

Yes. I've forgot to mention the images part.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Marxon13/M13PDFKit/issues/25#issuecomment-244217764, or mute the thread https://github.com/notifications/unsubscribe-auth/AQqc-Gd4QYcM91oCT5EsF1BI4SbJ6EPaks5ql0LvgaJpZM4Ioh5Z .

N.V.Saran Software Developer, Neemtec Solutions, 8220434718.

saran-metron avatar Sep 05 '16 04:09 saran-metron

The current repo, in swift, features enables practices that simply don't seem to work. At all. Frustrating to waste time on something so simple .. but the actual repo seems better than the others i have tried, except for this issue.

{edit: the issue seems to be that i am in a swift project and the repo is obj-c, and this may be why the value is not setting as "false" may be getting interpreted as YES.}

It might even be odder: i manually set the default in the repo to NO and yet it is still YES when running. I currently have no clue as i scanned the appropriate repo .m files that might be involved and see nowhere the YES is coming from.

wdcurry avatar Jul 18 '17 21:07 wdcurry

ps: if somebody with enough SO cred (1500) could create a tag for M13PDFKit, that would be great!

wdcurry avatar Jul 18 '17 23:07 wdcurry

The bug goes deeper. It looks like actually the settings are working BUT the toolbar is not refreshing until the button that should be gone is tapped, then it quickly animates away.

If i can't solve this, then surely the repo gets turfed as it cannot be presented in an app like that. Likely only a Swift thing. Sigh.

wdcurry avatar Jul 19 '17 04:07 wdcurry

Moving resetNavigationToolbar() out to the interface file (.h), then calling self.resetNavigationToolbar() after setting the enable's setting you require will force the reset of the navigationToolbar.

wdcurry avatar Jul 19 '17 05:07 wdcurry