Markus Westerlind

That seems like a mistake in this crate. Do you know of any other fields where this could be an issue? PRs appreciated!

@hannni Thanks for looking into this! > id in varying locations These refer to JSON-RPC request ids so they will always be an integer at least but it does seem...

I may sound a bit hesitant against changes in the above comment. That is just because the crate is meant to give users of the crate as many assurances about...

@vnagarnaik I'd be happy to accept a PR for changing `activeParameter` since that causes issues (or for any of the other instances).

[metaModel.json](https://github.com/microsoft/vscode-languageserver-node/blob/6a33b75c3520ad66d437c33ec9fc10d49a4675b8/protocol/metaModel.json) unfortunately seems to be a custom format, only the [schema for that json file](https://github.com/microsoft/vscode-languageserver-node/blob/6a33b75c3520ad66d437c33ec9fc10d49a4675b8/protocol/metaModel.schema.json) exists as a json schema. So https://github.com/Marwes/schemafy couldn't be used to generate the types (only...

Your function extracts a tuple, which doesn't seem right `fn cast_notification(not: lsp_server::Notification) -> Result `? Can't see any other tuples so that must be it

Is there something actionable on the crate side? You should be able to normalize the `Url` before using it as a key for the map. Maybe we could do this...

Can any request return a partial result? Not sure how this is supposed to work. Does it make sense to just provide a generic struct to be used if a...

Also, do we want re-export all the types currently in lib.rs after they are moved?

I guess `RefDoc` could take two lifetimes to separate the lifetime from the arena and the lifetime of the `&str` in `Doc`. That might fix the issues that you have.