combine icon indicating copy to clipboard operation
combine copied to clipboard

Published 20 hours ago • verified publisher icon Marwes

implement Trait?

Open droundy opened this issue 5 years ago • 2 comments

Now that implement Trait is stable, could you use it both for code and examples in order to simplify the API?

droundy avatar Nov 11 '18 15:11 droundy

There are some examples that uses impl Trait but I have held of using it in the library itself to enable combine to be used on older compilers.

Thanks to https://docs.rs/combine/3.6.2/combine/macro.parser.html I don't see a large win in readability from updating to impl Trait so weighing the pros and cons I rather stick with supporting older rustc's for the time being.

Marwes avatar Nov 15 '18 11:11 Marwes

Unfortunately issues such as https://github.com/rust-lang/rust/issues/42940 causes rustc to error in some cases where it shouldn't so this might not be possible to fix in 4.x

Marwes avatar Mar 14 '19 12:03 Marwes