Roman Marusyk comments

Results 51 comments of


                                            Roman Marusyk

Tips, improvements, suggestions

See https://github.com/Marusyk/grok.net/discussions/28

Tips, improvements, suggestions

Add more benchmarks

Tips, improvements, suggestions

See https://github.com/Marusyk/grok.net/pull/53

Add AppendQueryParam(s) methods

Hi @tmenier no problem put it on hold in the meanwhile, I'll update AppendQueryParam -> AppendQueryParams

SetQueryParams with collection of KV pairs, duplicate keys should append, not overwrite

It seems to be a breaking changes. Could you please advise if you wanna replace that logic or add some parameter for that? Then I'll try to prepare PR. Thx

fatal: unsafe repository ('/github/workspace' is owned by someone else)

refresh

fatal: unsafe repository ('/github/workspace' is owned by someone else)

thank you very much. good job

fatal: unsafe repository ('/github/workspace' is owned by someone else)

that's cool 😎 Keep it up, you're on the right way. Thanks for your contribution. Glad to have been of help 😉

[WIP] Add support for private feeds

What status of this feature?

Add service url to the aws s3 configuration model

To fix build you need to change this line https://github.com/loic-sharma/BaGet/blob/a3535852f20f45dc3225ee4f7ed3836e3c8cd977/tests/BaGet.Protocol.Tests/SearchClientTests.cs#L30 Because: Expected: 12.0.1 [Actual: 12.0.2](https://api-v2v3search-0.nuget.org/query?q=newtonsoft)