MartyIX
MartyIX
@sivMSFT @gourabkmsft Friendly ping
It would be great to have this `integrity` attribute. It appears that one can use https://www.srihash.org to manually get the integrity attribute.
> I think all this looks good, just had a nit about collapsing and reducing the if block complexity. Then you are going to have to use the proxy event...
tl;dr: The controls sample app I use for testing appears to work correctly with the latest commit (3e17515e1f144ddc109128d7d042e421f2a5c1cf). But I guess there are more scenarios which should be tested, hopefully...
Hm, `PageLayoutDoesNotExceedWindowBounds` failed. That looks like it might be an issue. However, I'm not really sure how to run that test on my mac machine (in VS Code).
@mattleibow Could you take a look please?
> @MartyIX to run the failing test you need to set this in your vs code Yeah, I figured it out in the meanwhile. Sorry for not updating the post....
Basically, this https://github.com/dotnet/maui/pull/24001/files#diff-3dbcd72ac0c8c03db5b1be3c27ad840dd2e0b30ab72ecb22a9f33d9b9bdd62b4R22 makes sure that we get `effectiveGeometry` updates but those updates take some time to come. But the test supposes that we know immediately window dimensions (I think).
@mattleibow Hey, could you take another look please?
@drasticactions Could you take a look please?