asynctest icon indicating copy to clipboard operation
asynctest copied to clipboard

Remove Decorators from asynctest

Open cooperlees opened this issue 5 years ago • 2 comments

Since 3.4 is no longer supported would a PR be accepted removing all the asyncto coroutine decorators? Using 0.13.0 I get errors like:

.tox/py3/lib/python3.9/site-packages/asynctest/mock.py:434
350  /home/travis/build/pypa/bandersnatch/.tox/py3/lib/python3.9/site-packages/asynctest/mock.py:434: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
351    def wait(self, skip=0):

More can been see on bandersntach tox runs here: https://travis-ci.org/pypa/bandersnatch/jobs/643198847?utm_medium=notification

cooperlees avatar Jan 29 '20 02:01 cooperlees

Yes, I believe that users who need old style coroutines can use an older version of asynctest.

On Wed, Jan 29, 2020, 03:53 Cooper Lees [email protected] wrote:

Since 3.4 is no longer supported would a PR be accepted removing all the decorators? Using 0.13.0 I get errors like:

.tox/py3/lib/python3.9/site-packages/asynctest/mock.py:434 350 /home/travis/build/pypa/bandersnatch/.tox/py3/lib/python3.9/site-packages/asynctest/mock.py:434: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead 351 def wait(self, skip=0):

More can been see on bandersntach tox runs here: https://travis-ci.org/pypa/bandersnatch/jobs/643198847?utm_medium=notification

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Martiusweb/asynctest/issues/147?email_source=notifications&email_token=AABPWGHDHCUUSWNSG5C4FADRADVTTA5CNFSM4KM5YDVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJNEN3Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABPWGAVJXV6R6Y52Z22J7DRADVTTANCNFSM4KM5YDVA .

Martiusweb avatar Jan 29 '20 08:01 Martiusweb

Is this still relevant ? Maybe release new version compatible with python 3.9 / 3.10 ? :thinking:

dinkopehar avatar Jan 16 '22 16:01 dinkopehar