Martin Machacek

Can I work on it?

Just a tiny note. The subcommand **add** can be confusing for some users because with this command we allow - create - adminAssign - update - adminUpdate, admindExtend - remove...

Hi @martinlingstuyl, it should be easy to adapt changes. It's working but hard to use, because it's not clear which options are required for which `action`. I haven't tested all...

@martinlingstuyl Maybe instead of `principalId` => `userId`, `userName`, `groupId`, `groupName` ? Related to `directoryScopeId`, allowed values are - `/` for tenant-wide scope - `/administrativeUnits/{administrativeUnitId}` to scope to an administrative unit...

@martinlingstuyl I would keep directoryScopeId and appScopeId. I will add remark to the doc how to use these options. Current spec looks great.

@martinlingstuyl Checking the spec, both duration and directoryScopeId has the same short option `-d`. Action option is missing

Ok, I was confused by 4th example where `action` option is still present. The endpoint support `endDateTime`, so the user can specify either `endDateTime` or `duration`

Hi @martinlingstuyl, probably last update in spec. According to [this conversation](https://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/9101#issuecomment-1935631887), we can get rid of `appScopeId` which is only allowed for entitlement management provider. In our case, we are...

@martinlingstuyl Based on https://github.com/pnp/cli-microsoft365/issues/5669#issuecomment-1941141838, should I rename the command and separate `role` and `assignment`? `m365 entra pim role assignment add [options]`

Can I take it?