Martin Hjelmare

Results 198 comments of Martin Hjelmare
trafficstars

As explained above we require a config flow for this kind of integration. https://developers.home-assistant.io/docs/config_entries_config_flow_handler As adding a config flow changes the scope of the PR, I'll close this PR now....

Besides the merge conflict, is this PR waiting for anything?

@markusressel If this PR is ready to merge, please mark it ready for review.

We should test this or write a test for it. Not sure how to do the latter though as we don't use the Home Assistant event helpers for the update...

It would be good to write a test, yes. With the event helper approach, will you calculate the schedule time depending on the number of nodes and schedule all updates...

Ok. I don't understand how the lock will work with that approach, but I'll take a look when you push.

It's not a breaking change anymore, right?

Maybe also update the PR description for the latest iteration of approach.

Duplicate of https://github.com/home-assistant/core/issues/80398