Fan Shangxiang comments

Results 136 comments of


                                            Fan Shangxiang

[WIP] Add support for specifying probe protocol / probe port via annotation per service port

/test pull-cloud-provider-azure-e2e-ccm-capz --

[WIP] Add support for specifying probe protocol / probe port via annotation per service port

/cherrypick release-1.25

[WIP] Add support for specifying probe protocol / probe port via annotation per service port

/cherrypick release-1.24

[WIP] Add support for specifying probe protocol / probe port via annotation per service port

/cherrypick release-1.23

Support ARM cross-tenant authentication

Is there any update on this pr? Thanks in advance!

The plugin will prevent backend from responding request because modal window is opened when plugin is installed in ide backend.

yes

chore(deps): bump golang from `9f880bd` to `1c3919e`

/retest

chore(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0

/retest

Health Probes do not gracefully shutdown traffic for externalTrafficPolicy Cluster services

The following annotation is added to change the probe port number for service. FYI service.beta.kubernetes.io/port_{port}_health-probe_port

Health Probes do not gracefully shutdown traffic for externalTrafficPolicy Cluster services

I think it is added. https://github.com/kubernetes-sigs/cloud-provider-azure/blob/b8b4145fdaf3578616979437c60acc90ca4ec249/pkg/provider/azure_loadbalancer.go#L2119