python-isc-dhcp-leases icon indicating copy to clipboard operation
python-isc-dhcp-leases copied to clipboard
verified publisher icon MartijnBraam

relax parsing rules to accept openbsd's dhcpd.leases format

Open rstms opened this issue 6 years ago • 5 comments

I made these changes because I needed this to run on my OpenBSD 6.4 system, which uses a dhcpd that is derived from isc-dhcpd. The dhcpd.leases file has minor differences which required changes to the parser. The existing tests all still pass.

These changes allow the module to read the OpenBSD lease file:

ignore 'UTC' suffix on time fields record with missing binding_state defaults to 'active' interpret 'abandoned;' field as 'binding_state abandoned;" added test case for openbsd dhcpd.leases added Makefile for make test

rstms avatar Apr 24 '19 05:04 rstms

Coverage Status

Coverage decreased (-23.0%) to 77.039% when pulling 7fc81df18be7441769f2abf59fd554a9295b1d61 on rstms:master into e96c00e31f3a52c01ef98193577d614d08a93285 on MartijnBraam:master.

coveralls avatar Apr 24 '19 05:04 coveralls

Coverage Status

Coverage decreased (-23.0%) to 77.039% when pulling 7fc81df18be7441769f2abf59fd554a9295b1d61 on rstms:master into e96c00e31f3a52c01ef98193577d614d08a93285 on MartijnBraam:master.

coveralls avatar Apr 24 '19 05:04 coveralls

Coverage Status

Coverage decreased (-23.0%) to 77.039% when pulling 7fc81df18be7441769f2abf59fd554a9295b1d61 on rstms:master into e96c00e31f3a52c01ef98193577d614d08a93285 on MartijnBraam:master.

coveralls avatar Apr 24 '19 05:04 coveralls

Thanks for the PR!, the code looks good but the unit test is broken because you've added a method to the test case with the same name as another method, so most tests don't run currently.

MartijnBraam avatar Apr 30 '19 16:04 MartijnBraam

Hello, Sorry for necrobumping this PR, but I really wish it to be merged. @rstms Is this a problem to fix the unit tests?

raspbeguy avatar Oct 13 '21 09:10 raspbeguy