Martchus
Martchus
I've been building Syncthing as a library since quite a while and it works nicely so far. I can only think of two things which could be improved but both...
By the way, I think the most important point of my review was that this should be put behind a configuration option and be disabled by default - at least...
@sdclarke You're not actively working on this, right? I would take over as we'd actually also like to have this feature ourselves (see https://progress.opensuse.org/issues/154783). I would keep your commits as-is...
I've just pushed an update which should resolve all my previous review comments. This leaves: * Add UI tests for the test details page * Avoid problems when this runs...
See https://progress.opensuse.org/issues/154783#note-10 for the most recent update on this.
Also see https://progress.opensuse.org/issues/154783#note-10 and my subsequent comments in that ticket for what's left.
The minimum effort we need to put into this PR to be mergable is: 1. Resolve conflicts 2. Ensure test coverage checks pass (I suppose UI tests are missing) 3....
> Assuming I can deal with the test coverage issues, would that be enough to get this merged for now? From my perspective it would be good to get this...
This PR can be closed now that https://github.com/os-autoinst/openQA/pull/6190 has been merged. This means the exact details of how this works have changed compared to what was proposed here. So if...
This is not a new idea. I guess we just never had the time to implement it.