marquez icon indicating copy to clipboard operation
marquez copied to clipboard

Use `io.openlineage.server.*` pkg and add class `Metadata`

Open wslulciuc opened this issue 1 year ago • 1 comments

This PR removes the OpenLineage models that were first introduced in the PoC in favor of io.openlineage.server.* defined specifically for consumers. This PR also introduces classes Metadata and VersionId. Below, we outlined more specifically on their importance and usage.

class Metadata

Wrapper class for parsing:

  • class OpenLineage.RunEvent
  • class OpenLineage.JobEvent
  • class OpenLineage.DatasetEvent

Methods:

  • Metadata.newRunFor(OpenLineage.RunEvent): Metadata.Run
  • Metadata.newJobFor(OpenLineage.JobEvent): Metadata.Job
  • Metadata.newDatasetFor(OpenLineage.DatasetEvent): Metadata.Dataset

class VersionId

Factory class for VersionIds.

Methods:

  • VersionId.forJob(): VersionId
  • VersionId.forDataset(): VersionId

Closes: https://github.com/MarquezProject/marquez/issues/1650

wslulciuc avatar Jul 12 '24 18:07 wslulciuc

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit 21e1ecbd8978711f6815831c28f4e4be7b1c8a13
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6706e95795ea9d0008303d1d

netlify[bot] avatar Jul 12 '24 18:07 netlify[bot]

Codecov Report

Attention: Patch coverage is 64.95957% with 130 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (c7e0d63) to head (21e1ecb). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/src/main/java/marquez/api/models/Metadata.java 77.16% 64 Missing and 2 partials :warning:
...ain/java/marquez/api/exceptions/FacetNotValid.java 0.00% 57 Missing :warning:
.../src/main/java/marquez/common/models/RunState.java 40.00% 5 Missing and 1 partial :warning:
...pi/src/main/java/marquez/api/models/VersionId.java 92.85% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2853      +/-   ##
============================================
- Coverage     83.08%   82.15%   -0.93%     
- Complexity     1500     1504       +4     
============================================
  Files           265      268       +3     
  Lines          6888     7258     +370     
  Branches        320      325       +5     
============================================
+ Hits           5723     5963     +240     
- Misses         1007     1134     +127     
- Partials        158      161       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 03 '24 19:10 codecov[bot]