marquez icon indicating copy to clipboard operation
marquez copied to clipboard

Use webpack bundled icon instead of GitHub hosted content

Open dodo0822 opened this issue 10 months ago • 3 comments

Problem

Currently the Events item in Sidenav uses the icon hosted in GitHub, which may cause issue with strict Content-Security-Policy settings.

image

Solution

One-line summary: use the icon SVG bundled by Webpack instead of linking to raw.githubusercontent.com.

Checklist

  • [x] You've signed-off your work
  • [ ] Your changes are accompanied by tests (if relevant)
  • [x] Your change contains a small diff and is self-contained
  • [ ] You've updated any relevant documentation (if relevant)
  • [ ] You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • [ ] You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • [ ] You've included a header in any source code files (if relevant)

dodo0822 avatar Apr 25 '24 06:04 dodo0822

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

boring-cyborg[bot] avatar Apr 25 '24 06:04 boring-cyborg[bot]

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit 59d0a5eedf5ed9584b062e61af338da8724639c7
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/663000865910b20008930c18

netlify[bot] avatar Apr 25 '24 06:04 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.47%. Comparing base (ab46957) to head (3d3c7af).

:exclamation: Current head 3d3c7af differs from pull request most recent head 59d0a5e. Consider uploading reports for the commit 59d0a5e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2803   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 25 '24 06:04 codecov[bot]

Great job! Congrats on your first merged pull request in the Marquez project!

boring-cyborg[bot] avatar Apr 29 '24 20:04 boring-cyborg[bot]