marquez icon indicating copy to clipboard operation
marquez copied to clipboard

Add job tagging to API

Open davidsharp7 opened this issue 11 months ago • 3 comments

Problem

Currently we have no tag support for jobs.

Closes: #2756

Solution

  • Adding new table jobs_tag_mapping to store the relationship between jobs and tags.
  • Update jobs meta to return the tags as a list.
  • Add POST/DELETE end points to add and delete tags.
Screenshot 2024-03-17 at 22 26 30 Screenshot 2024-03-17 at 22 27 01 One-line summary:

Add job tagging to API

Checklist

  • [x] You've signed-off your work
  • [x] Your changes are accompanied by tests (if relevant)
  • [x] Your change contains a small diff and is self-contained
  • [x] You've updated any relevant documentation (if relevant)
  • [x] You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • [x] You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • [x] You've included a header in any source code files (if relevant)

davidsharp7 avatar Mar 17 '24 09:03 davidsharp7

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit bf6621e59a1c59e654d3c9fa09702451cf2e2e80
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/663a4ce80f1807000836ffb4

netlify[bot] avatar Mar 17 '24 09:03 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.57%. Comparing base (ae794a9) to head (10703c1).

:exclamation: Current head 10703c1 differs from pull request most recent head bf6621e. Consider uploading reports for the commit bf6621e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2774      +/-   ##
============================================
+ Coverage     84.47%   84.57%   +0.09%     
- Complexity     1430     1441      +11     
============================================
  Files           251      251              
  Lines          6462     6503      +41     
  Branches        299      302       +3     
============================================
+ Hits           5459     5500      +41     
  Misses          850      850              
  Partials        153      153              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 19 '24 21:03 codecov[bot]

It's a 137 exit code which is OOM so yes you out of resource. Did this a couple of weeks ago and then came right.

davidsharp7 avatar Apr 25 '24 17:04 davidsharp7