marquez
marquez copied to clipboard
Make db port configurable via `POSTGRES_PORT`
Problem
Currently, changing the db port requires modifying several different yml files in the project related to the Docker configuration.
Solution
This makes configuring the db port more developer-friendly by replacing the db port assignments with the existing env var, POSTGRES_PORT
. It is given a default value of 5432
in up.sh
.
Note: All database schema changes require discussion. Please link the issue for context.
One-line summary: reconfigure docker compose to support easy db port reassignment
Checklist
- [x] You've signed-off your work
- [ ] Your changes are accompanied by tests (if relevant)
- [x] Your change contains a small diff and is self-contained
- [ ] You've updated any relevant documentation (if relevant)
- [x] You've included a one-line summary of your change for the
CHANGELOG.md
(Depending on the change, this may not be necessary). - [ ] You've versioned your
.sql
database schema migration according to Flyway's naming convention (if relevant) - [ ] You've included a header in any source code files (if relevant)
Deploy Preview for peppy-sprite-186812 canceled.
Name | Link |
---|---|
Latest commit | 6aa5a5e8c61e17a01bac416b0476b56dcea878f4 |
Latest deploy log | https://app.netlify.com/sites/peppy-sprite-186812/deploys/664d582fa0c05d00088eaf1e |
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
87dcdf6
) 80.63% compared to head (ff2d297
) 84.45%. Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2751 +/- ##
============================================
+ Coverage 80.63% 84.45% +3.82%
- Complexity 234 1416 +1182
============================================
Files 43 251 +208
Lines 976 6447 +5471
Branches 38 291 +253
============================================
+ Hits 787 5445 +4658
- Misses 160 850 +690
- Partials 29 152 +123
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.