marquez
marquez copied to clipboard
Add pagination to JobDetailPage
Problem
We don't yet have pagination on the JobDetailPage's Run History tab for runs like we do for datasets and jobs on those routes.
Solution
This uses the same approach employed in those cases to add pagination to the JobDetailPage. As in those cases, here, the API is queried to ensure an accurate count. But, unlike those cases, we lacked a query to get the total run count, so one has been added to RunDao.
Note: All database schema changes require discussion. Please link the issue for context.
One-line summary: adds pagination to JobDetailPage.
Checklist
- [x] You've signed-off your work
- [ ] Your changes are accompanied by tests (if relevant)
- [x] Your change contains a small diff and is self-contained
- [ ] You've updated any relevant documentation (if relevant)
- [x] You've included a one-line summary of your change for the
CHANGELOG.md
(Depending on the change, this may not be necessary). - [ ] You've versioned your
.sql
database schema migration according to Flyway's naming convention (if relevant) - [ ] You've included a header in any source code files (if relevant)
Deploy Preview for peppy-sprite-186812 canceled.
Name | Link |
---|---|
Latest commit | 5f26f286c37bb89f7fdb67da268992cf758d99a5 |
Latest deploy log | https://app.netlify.com/sites/peppy-sprite-186812/deploys/66200d56c2343b00085c5850 |
Codecov Report
Merging #2656 (21be09d) into main (42cadbb) will increase coverage by
0.00%
. Report is 1 commits behind head on main. The diff coverage is100.00%
.
:exclamation: Current head 21be09d differs from pull request most recent head 9d1ca3e. Consider uploading reports for the commit 9d1ca3e to get more accurate results
@@ Coverage Diff @@
## main #2656 +/- ##
=========================================
Coverage 83.60% 83.61%
Complexity 1334 1334
=========================================
Files 245 245
Lines 6076 6077 +1
Branches 280 280
=========================================
+ Hits 5080 5081 +1
Misses 844 844
Partials 152 152
Files | Coverage Δ | |
---|---|---|
api/src/main/java/marquez/api/JobResource.java | 93.15% <100.00%> (+0.09%) |
:arrow_up: |
api/src/main/java/marquez/db/RunDao.java | 94.49% <ø> (ø) |
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
@merobi-hub We need to update the openapi spec and regenerate the docs for the doc section of the website as well here.
@merobi-hub Pinging you on this one. It's a feature we would very much like to have. I think you are on the right track here, but the API is failing CI.
@phixMe When I was working on this, I couldn't diagnose the issues with the API. But I'll take another look when I have a moment.