marquez icon indicating copy to clipboard operation
marquez copied to clipboard

Add PMD plugin to build.gradle

Open merobi-hub opened this issue 2 years ago • 3 comments

Signed-off-by: Michael Robinson [email protected]

Problem

A static code analysis plugin, required by the LFAI, was removed from the project.

Closes: #1976

Solution

The PR adds PMD to the project. The configuration is identical to the setup we used in OpenLineage. To run it locally use: ./gradlew check. Reports can be found in api/build/reports/pmd/.

Checklist

  • [x] You've signed-off your work
  • [ ] Your changes are accompanied by tests (if relevant)
  • [x] Your change contains a small diff and is self-contained
  • [ ] You've updated any relevant documentation (if relevant)
  • [ ] You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • [ ] You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

merobi-hub avatar Jun 03 '22 14:06 merobi-hub

Codecov Report

Merging #2011 (bd81330) into main (0213210) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2011   +/-   ##
=========================================
  Coverage     75.14%   75.14%           
  Complexity     1023     1023           
=========================================
  Files           202      202           
  Lines          4836     4836           
  Branches        392      392           
=========================================
  Hits           3634     3634           
  Misses          762      762           
  Partials        440      440           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 03 '22 14:06 codecov[bot]

ee0989e doesn't include a fix for the logging/errors problem mentioned in the issue.

merobi-hub avatar Jun 03 '22 14:06 merobi-hub

@merobi-hub: Let me know if you need any clarification on my about adding the spotbugs plugin to the root build.gradle.

wslulciuc avatar Jun 24 '22 18:06 wslulciuc