Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

Cosmetic changes to DWIN/E3V2 UI's

Open classicrocker883 opened this issue 1 year ago • 3 comments

Description

Mostly updating CrealityUI + ProUI spacing. Some tweaking of comments.

  • Removed whitespace and unnecessary spacing
  • Use GET_TEXT_F and MSG_... from language_en.h instead of literal Strings in CrealityUI, which was a TODO:

No other real important code changes, merely just cosmetic or rearranging of code

  • Removed single use MSG_UBL_MESH_LEVELING, swap w/`MSG_MESH_LEVELING

Requirements

Benefits

Less clumped, crowded. Better readability.

Configurations

Related Issues

classicrocker883 avatar Apr 17 '24 12:04 classicrocker883

@classicrocker883 just to let you know, I'm avoiding merging anything with cosmetic changes. The style of Marlin is hard to decipher, and outside of thinkyhead most of us don't really know what changes are welcome.

I'm happy to review and merge bug fixes or or other functional changes if their benefit is clear and I understand the change, but the presence of any cosmetic "cleanup" mixed in makes it much harder for me to consider merging.

sjasonsmith avatar Apr 21 '24 00:04 sjasonsmith

I also think the title calling this PR "cosmetic" changes is incomplete. It seems like you have several other improvements (or at least changes) mixed in with the truly cosmetic changes, which would be nice to evaluate on their own.

sjasonsmith avatar Apr 21 '24 00:04 sjasonsmith

This PR is ready for merge

classicrocker883 avatar May 30 '24 02:05 classicrocker883