Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

Published 20 hours ago • verified publisher icon MarlinFirmware

Fix bed leveling issues

Open ellensp opened this issue 1 year ago • 1 comments
trafficstars

Description

Two bugs

  1. a while loop in line_to_destination_cartesian can loop forever. Code has while (cnt) but variable cnt is a structure with a X and a Y component. This while does not end. Replaced with while (cnt.x || cnt.y)

  2. After https://github.com/MarlinFirmware/Marlin/commit/ba08dcfb76804a912380603b3f69831ea0d1d6eb MESH_BED_LEVELING with SEGMENT_LEVELED_MOVES disabled fails to build. Updated variable types to be unsigned.

Requirements

Bed leveling (UBL or MESH) with SEGMENT_LEVELED_MOVES disabled

Benefits

Works as expected

Related Issues

  • MarlinFirmware/Marlin/issues/26816
  • MarlinFirmware/Marlin/issues/26718

    • ellensp avatar Feb 26 '24 13:02 ellensp

    i have a question, for cartesian beds, is it better to have SEGMENT_LEVELED_MOVES? and what would the advantages/disadvantages be for being defined or undefined?

    classicrocker883 avatar Feb 27 '24 10:02 classicrocker883

    closing as sjasonsmith found a better fix. https://github.com/MarlinFirmware/Marlin/pull/26936 That fixes the bool operation in XYval, vs just avoiding the broken bool

    ellensp avatar Apr 05 '24 00:04 ellensp

    closing as sjasonsmith found a better fix. #26936 That fixes the bool operation in XYval, vs just avoiding the broken bool

    What about the MBL bug?

    thisiskeithb avatar Apr 05 '24 00:04 thisiskeithb

    oh darn, its a two parter... part 1 is addressed by https://github.com/MarlinFirmware/Marlin/pull/26936 But part 2... updated PR to just address this

    ellensp avatar Apr 05 '24 00:04 ellensp