Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

Published 20 hours ago • verified publisher icon MarlinFirmware

[WEBSUPPORT ON ESP3D_WIFISUPPORT] (WEBSUPPORT working on 2.1.2.1 but no in 2.1.2.2)

Open Skeleton84 opened this issue 1 year ago • 3 comments

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Some change in Configuration_adv.h, in new version now no chance to enable WEBSUPPORT, OTASUPPORT on tinybee (ESP3D_WIFISUPPORT) only change is #if EITHER(WIFISUPPORT, ESP3D_WIFISUPPORT) to now: #if ENABLED(WIFISUPPORT) Code works fine but without webserver. How to enable WEBSUPPORT, OTASUPPORT without errors?

In 2.1.2.2:

//#define WIFISUPPORT         // Marlin embedded WiFi management. Not needed for simple WiFi serial port.
#define ESP3D_WIFISUPPORT   // ESP3D Library WiFi management (https://github.com/luc-github/ESP3DLib)

/**
 * Extras for an ESP32-based motherboard with WIFISUPPORT
 * These options don't apply to add-on WiFi modules based on ESP32 WiFi101.
 */
#if ENABLED(WIFISUPPORT)
  #define WEBSUPPORT          // Start a webserver (which may include auto-discovery) using SPIFFS
  #define OTASUPPORT          // Support over-the-air firmware updates
  #define WIFI_CUSTOM_COMMAND // Accept feature config commands (e.g., WiFi ESP3D) from the host
  //AUTHENTICATION_FEATURE: protect pages by login password.
  #define AUTHENTICATION_FEATURE
  /**
   * To set a default WiFi SSID / Password, create a file called Configuration_Secure.h with
   * the following defines, customized for your network. This specific file is excluded via
   * .gitignore to prevent it from accidentally leaking to the public.
   *
   *   #define WIFI_SSID "WiFi SSID"
   *   #define WIFI_PWD  "WiFi Password"
   */
  //#include "Configuration_Secure.h" // External file with WiFi SSID / Password
#endif

in 2.1.2.1:

//#define WIFISUPPORT         // Marlin embedded WiFi management
#define ESP3D_WIFISUPPORT   // ESP3D Library WiFi management (https://github.com/luc-github/ESP3DLib)

#if EITHER(WIFISUPPORT, ESP3D_WIFISUPPORT)
  #define WEBSUPPORT          // Start a webserver (which may include auto-discovery)
  #define OTASUPPORT          // Support over-the-air firmware updates
  #define WIFI_CUSTOM_COMMAND // Accept feature config commands (e.g., WiFi ESP3D) from the host
  //AUTHENTICATION_FEATURE: protect pages by login password.
  #define AUTHENTICATION_FEATURE
  /**
   * To set a default WiFi SSID / Password, create a file called Configuration_Secure.h with
   * the following defines, customized for your network. This specific file is excluded via
   * .gitignore to prevent it from accidentally leaking to the public.
   *
   *   #define WIFI_SSID "WiFi SSID"
   *   #define WIFI_PWD  "WiFi Password"
   */
  //#include "Configuration_Secure.h" // External file with WiFi SSID / Password
#endif

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.2.2

Printer model

Creality Ender-3 Pro

Electronics

mks-tinybee

LCD/Controller

CR10_STOCKDISPLAY

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • [X] A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Marlin.zip

Skeleton84 avatar Feb 12 '24 09:02 Skeleton84

Please download bugfix-2.1.x to test with the latest code and let us know if you're still having this issue.

thisiskeithb avatar Feb 12 '24 13:02 thisiskeithb

Please download bugfix-2.1.x to test with the latest code and let us know if you're still having this issue.

yes i tried this today again with your link, but webserver not working, same as version 2.1.2.2, now i revert back to 2.1.2.1 and webserver working fine.

Skeleton84 avatar Feb 13 '24 06:02 Skeleton84

I can confirm this too. I have a Tinybee board too, I had to change #if ENABLED(WIFISUPPORT) to #if ANY(WIFISUPPORT, ESP3D_WIFISUPPORT) to make it work. #if EITHER(WIFISUPPORT, ESP3D_WIFISUPPORT) will work too.

PanosPetrou avatar Feb 17 '24 18:02 PanosPetrou

Same issue here - same board (WiFi set as AP). The fix above doesn't work on the latest bugfix release. I had to do this:

/**
 * Native ESP32 board with WiFi or add-on ESP32 WiFi-101 module
 */
//#define WIFISUPPORT         // Marlin embedded WiFi management. Not needed for simple WiFi serial port.
#define ESP3D_WIFISUPPORT   // ESP3D Library WiFi management (https://github.com/luc-github/ESP3DLib)

/**
 * Extras for an ESP32-based motherboard with WIFISUPPORT
 * These options don't apply to add-on WiFi modules based on ESP32 WiFi101.
 */
#if ANY(WIFISUPPORT, ESP3D_WIFISUPPORT)
  #define WEBSUPPORT          // Start a webserver (which may include auto-discovery) using SPIFFS
  // #define OTASUPPORT          // Support over-the-air firmware updates
  // #define WIFI_CUSTOM_COMMAND // Accept feature config commands (e.g., WiFi ESP3D) from the host

  /**
   * To set a default WiFi SSID / Password, create a file called Configuration_Secure.h with
   * the following defines, customized for your network. This specific file is excluded via
   * .gitignore to prevent it from accidentally leaking to the public.
   *
   *   #define WIFI_SSID "WiFi SSID"
   *   #define WIFI_PWD  "WiFi Password"
   */
  //#include "Configuration_Secure.h" // External file with WiFi SSID / Password
#endif

Sanitycheck throws errors if OTASUPPORT or WIFI_CUSTOM_COMMAND are enabled.

HoverClub avatar Feb 23 '24 18:02 HoverClub

I've opened https://github.com/MarlinFirmware/Marlin/pull/26822 with a fix.

thisiskeithb avatar Feb 26 '24 21:02 thisiskeithb

i tried this out still on latest bugfix still not working on my mks tinybee

Same issue here - same board (WiFi set as AP). The fix above doesn't work on the latest bugfix release. I had to do this:

/**
 * Native ESP32 board with WiFi or add-on ESP32 WiFi-101 module
 */
//#define WIFISUPPORT         // Marlin embedded WiFi management. Not needed for simple WiFi serial port.
#define ESP3D_WIFISUPPORT   // ESP3D Library WiFi management (https://github.com/luc-github/ESP3DLib)

/**
 * Extras for an ESP32-based motherboard with WIFISUPPORT
 * These options don't apply to add-on WiFi modules based on ESP32 WiFi101.
 */
#if ANY(WIFISUPPORT, ESP3D_WIFISUPPORT)
  #define WEBSUPPORT          // Start a webserver (which may include auto-discovery) using SPIFFS
  // #define OTASUPPORT          // Support over-the-air firmware updates
  // #define WIFI_CUSTOM_COMMAND // Accept feature config commands (e.g., WiFi ESP3D) from the host

  /**
   * To set a default WiFi SSID / Password, create a file called Configuration_Secure.h with
   * the following defines, customized for your network. This specific file is excluded via
   * .gitignore to prevent it from accidentally leaking to the public.
   *
   *   #define WIFI_SSID "WiFi SSID"
   *   #define WIFI_PWD  "WiFi Password"
   */
  //#include "Configuration_Secure.h" // External file with WiFi SSID / Password
#endif

Sanitycheck throws errors if OTASUPPORT or WIFI_CUSTOM_COMMAND are enabled.

kyon03 avatar Mar 22 '24 05:03 kyon03

Patch for 2.1.x submitted:

  • https://github.com/MarlinFirmware/Marlin/pull/27025

thisiskeithb avatar Apr 28 '24 00:04 thisiskeithb

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Jun 27 '24 01:06 github-actions[bot]