Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

Update Configuration files - comments

Open classicrocker883 opened this issue 1 year ago • 6 comments

Description

Follow up to my previous PR | commit "🎨 Followup to optional M111/M115 (https://github.com/MarlinFirmware/Marlin/pull/26626)" Update Configuration.h + Configuration_adv.h

Make a couple rearrangements, Reword things like "Note:" to "NOTE:", and "Warning:" to "WARNING:"

Requirements

Benefits

Improves comment legibility

Configurations

Related Issues

  • fixed a typo in config_adv.h file (M114_DETAIL)
  • fixed spacing / extra line

classicrocker883 avatar Jan 05 '24 15:01 classicrocker883

b631b48 / b9f104d / 9b406ef / Pro UI fixes should be a separate PR.

thisiskeithb avatar Jan 05 '24 22:01 thisiskeithb

b631b48 / b9f104d / 9b406ef / Pro UI fixes should be a separate PR.

youre right this was meant for https://github.com/MarlinFirmware/Marlin/pull/26563 ok this was reverted

classicrocker883 avatar Jan 05 '24 22:01 classicrocker883

Some changes here are also in your other open PRs. Why are you opening multiple PRs?

It's been said already, but there are a lot more important development issues to focus on, so please review our Issue queue if you’re looking for something to work on. Bug reports marked as confirmed would be a good start.

thisiskeithb avatar Jan 05 '24 22:01 thisiskeithb

Some changes here are also in your other open PRs. Why are you opening multiple PRs?

whoops I was supposed to revert ones with same changes

classicrocker883 avatar Jan 06 '24 00:01 classicrocker883

[!NOTE] This and other nonessential PRs are being held until after the upcoming release of 2.1.3. Although I am making tools to automate the migration of settings to newer configurations, this additional massive set of changes overburdens users who use 'diff' to migrate settings from a previous version. That will be less of an issue once robust migration tools are completed (time allowing).

thinkyhead avatar Jan 06 '24 05:01 thinkyhead

@thinkyhead I have a couple other PR, I might like to merge one with another. would that help speed things up, or should it be left alone?

because that would then close one PR, with all the comments and such.
on the other hand, it would combine similar files that need changing.

classicrocker883 avatar Jan 06 '24 06:01 classicrocker883