Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

✨Mellow Fly E3 Pro V3 (STM32F407VG)

Open jaysuk opened this issue 1 year ago • 17 comments

Description

Based on the Fly-E3-v2 mainboard that was merged into Marlin, this is for the Fly-E3-Pro-V3

Requirements

A Fly-E3-Pro-V3

Benefits

Adds support for the Fly-E3-Pro-V3 board

Configurations

Related Issues

None

jaysuk avatar Aug 30 '23 18:08 jaysuk

Since this is a duplicate PR, it'd be better to send PRs to https://github.com/MarlinFirmware/Marlin/pull/25894 / https://github.com/IoakeimSogiakas/Marlin/tree/FLY_RRF_MARLIN

thisiskeithb avatar Aug 30 '23 20:08 thisiskeithb

i've sent a message to the author but not heard anything back. can we not just merge this one and close the other PR?

jaysuk avatar Sep 03 '23 11:09 jaysuk

can we not just merge this one and close the other PR?

That’s not how it generally works. Users collaborate via a single PR/fork, not open multiple PRs.

thisiskeithb avatar Sep 03 '23 11:09 thisiskeithb

PR https://github.com/MarlinFirmware/Marlin/pull/25894 closed, superseded with this on of this one

ellensp avatar Sep 03 '23 11:09 ellensp

I guess that settles that.

thisiskeithb avatar Sep 03 '23 11:09 thisiskeithb

original pr was not finished and seems to be abandoned. this is a step forward

ellensp avatar Sep 03 '23 11:09 ellensp

@ellensp thanks

jaysuk avatar Sep 03 '23 11:09 jaysuk

As far as I'm concerned this is ready to merge

jaysuk avatar Sep 05 '23 16:09 jaysuk

anything else i need to do with this?

jaysuk avatar Sep 15 '23 13:09 jaysuk

be patent, main developer is taking a break for an unknown period of time

ellensp avatar Sep 15 '23 13:09 ellensp

@jaysuk can you update this to work with the latest bugfix-2.1.x and push new changes? If so we should be able to do a final review of this and get it in soon.

sjasonsmith avatar Nov 21 '23 07:11 sjasonsmith

@sjasonsmith updated to the latest. only had to change the boards file

jaysuk avatar Nov 21 '23 07:11 jaysuk

I also just pushed 55a109e to fix a few small things in pins_MELLOW_FLY_E3_PRO_V3.h.

thisiskeithb avatar Nov 21 '23 07:11 thisiskeithb

thanks, didn't even think to check those. Once this is merged I will move on to the next board. I still have the Fly-CDYv3 and Super8 boards to do in the F4 range. Then its on to the H7 ones

jaysuk avatar Nov 21 '23 07:11 jaysuk

i checked all the pins against the pinouts of the modules etc. i maintain all the docs for the RRF port so i know the boards "fairly" well

jaysuk avatar Nov 21 '23 18:11 jaysuk

PR has been brought up to date & I've pushed some more updates to pins_MELLOW_FLY_E3_PRO_V3.h. See my question above about flash drive support.

thisiskeithb avatar Apr 25 '24 13:04 thisiskeithb

I just discovered this note about the Mellow Fly E3 Pro V3's thermistor pull-ups:

[!IMPORTANT] The Fly-E3-Pro-v3 uses a 2k2 resistor on the thermistor inputs rather than 4k7. Please make sure you add R2200 to each M308 in your config

I ran into this while working on LDO Leviathan board support and it means that users will have select thermistor 1000 for any thermistor they want to use and will have to define all the custom thermistor 1000 parameters found in Configuration_adv.h since Marlin assumes 4.7K as the default pull-up type for most thermistors.

I also saw the note about needing to add jumpers on Z2's output (I assume they are driven in series?), so adding a warning to the pins file would be a good idea.

thisiskeithb avatar Apr 25 '24 15:04 thisiskeithb