Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

[BUG] platforms.h HAL_STM32 compile error (FIX)

Open classicrocker883 opened this issue 1 year ago • 2 comments

as you can see this does not work

platforms.h line 40

#elif defined(ARDUINO_ARCH_STM32)
  #ifndef HAL_STM32
    #define HAL_STM32
  #endif
  #define HAL_PATH(PATH, NAME) XSTR(PATH/STM32/NAME)

instead it should be written like this

#elif defined(ARDUINO_ARCH_STM32) || defined(HAL_STM32)

after it is like this no problems are detected

well i guess technically it is fine without the change, but to help mitigate compile errors

classicrocker883 avatar Aug 27 '22 07:08 classicrocker883

What is the error and how do we reproduce it?

Bob-the-Kuhn avatar Aug 27 '22 09:08 Bob-the-Kuhn

when using PROUI it doesnt really give an error. but it shows problems as though it isnt defined. this helps keep the reported problems down. at least on my end

classicrocker883 avatar Aug 27 '22 10:08 classicrocker883

I'm also not understanding how this is misbehaving. If HAL_PATH wasn't being defined you should have hit the #error case at the bottom of the file. It shouldn't be silently failing.

@classicrocker883 for anything to happen with this you will need to provide your configuration headers which are being impacted by this.

sjasonsmith avatar Sep 29 '22 04:09 sjasonsmith

Closing, since we can't really tell what the problem is and OP is unresponsive.

sjasonsmith avatar Oct 17 '22 20:10 sjasonsmith