Marlin icon indicating copy to clipboard operation
Marlin copied to clipboard

Elegoo Neptune Boards

Open mlee12382 opened this issue 2 years ago • 14 comments

Description

Added new board definitions and pins and updated .ini files for platformio for the Elegoo Neptune series of printers.

Requirements

N/A

Benefits

Adds boards to make custom compiling firmware for the Elegoo Neptune series of printers easier, duplicates and renames the 2 boards that come in the Neptune 2 printers to make it more straightforward and adds the missing board files for the Neptune X and Neptune 3

Configurations

N/A

Related Issues

N/A

mlee12382 avatar Jul 30 '22 00:07 mlee12382

Redundant, ZNP_ROBIN_NANO is exactly same as MKS_ROBIN_NANO

EvilGremlin avatar Jul 30 '22 01:07 EvilGremlin

Redundant, ZNP_ROBIN_NANO is exactly same as MKS_ROBIN_NANO

The board is a clone of the MKS but it is labeled ZNP on the control board, the redundancy is to avoid confusion for people wanting to build their own custom firmware.

mlee12382 avatar Jul 30 '22 01:07 mlee12382

MKS Robin (nano) E3 also exist already. Which leaves quiestion: is Neptune X board unique or also rebadge of something else?

To avoid confusion simple name alias is more than enough, no need to make a copy of pin files #elif MB(ZNP_ROBIN_NANO) #include "stm32f1/pins_MKS_ROBIN_NANO.h" like that

EvilGremlin avatar Jul 30 '22 01:07 EvilGremlin

MKS Robin (nano) E3 also exist already. Which leaves quiestion: is Neptune X board unique or also rebadge of something else?

To avoid confusion simple name alias is more than enough, no need to make a copy of pin files #elif MB(ZNP_ROBIN_NANO) #include "stm32f1/pins_MKS_ROBIN_NANO.h" like that

Neptune X is unique as is Neptune 3, I think that's how I did the znp robin boards was just as aliases in boards.h

mlee12382 avatar Jul 30 '22 01:07 mlee12382

Do you have board photos? Google is silent about new ones

EvilGremlin avatar Jul 30 '22 01:07 EvilGremlin

Only these from the user guides for the Neptune X and Neptune 3, do you need the Neptune 2 boards also? NEPTUNE X NEPTUNE 3

mlee12382 avatar Jul 30 '22 01:07 mlee12382

Neptune X is robin nano 1.3... defines USES_DIAG_JUMPERS and CS pins etc but photo says there are none

EvilGremlin avatar Jul 30 '22 01:07 EvilGremlin

Neptune X is robin nano 1.3...

No the pins don't match anything currently in marlin. Neptune-X

mlee12382 avatar Jul 30 '22 01:07 mlee12382

It's close but not 100% match

mlee12382 avatar Jul 30 '22 02:07 mlee12382

Yep, i see... a bit of a mess. Do you have actual hardware to verify pinouts? Bacause this neptune X v1.0 photo clearly don't match pins.

EvilGremlin avatar Jul 30 '22 02:07 EvilGremlin

Yep, i see... a bit of a mess. Do you have actual hardware to verify pinouts? Bacause this neptune X v1.0 photo clearly don't match pins.

No unfortunately not :( I am trying to help out the community cause we've been lacking firmware other than stock for the X and the 3 is brand new. I may need to do a bit more research it seems.

mlee12382 avatar Jul 30 '22 02:07 mlee12382

Neptune X is robin nano 1.3... defines USES_DIAG_JUMPERS and CS pins etc but photo says there are none

I copied the nano_v3 and modified the pins since that is what elegoo said was the board they cloned and modified, I can remove that definition if it's not relevant.

mlee12382 avatar Jul 30 '22 02:07 mlee12382

Nah, let's leave it as is for now. Maybe someone with hardware will show up to verify.

EvilGremlin avatar Jul 30 '22 02:07 EvilGremlin

Nah, let's leave it as is for now. Maybe someone with hardware will show up to verify.

I just noticed that the cs pins interfere with the fsmc pins, not sure why I didn't catch that before, will fix it real quick.

mlee12382 avatar Jul 30 '22 02:07 mlee12382

Does this need additional verification or should it be merged in its current state?

thinkyhead avatar Aug 19 '22 15:08 thinkyhead

Does this need additional verification or should it be merged in its current state?

I need to do more work on this before it's ready for merging unfortunately :(

mlee12382 avatar Aug 19 '22 16:08 mlee12382

I realize this is closed, but would a picture of the board help here? If not, what do you need @mlee12382?

NotLordCalvert avatar Sep 24 '22 08:09 NotLordCalvert

I realize this is closed, but would a picture of the board help here? If not, what do you need @mlee12382?

For the Neptune 3 I need to figure out why it is having trouble compiling and why the SanityCheck is convinced that E0_AUTO_FAN_PIN is set to FAN_PIN when it's not. The "official" N3 firmware bypasses that line of the SanityCheck instead of fixing the underlying issue which won't fly with the actual Marlin git.

mlee12382 avatar Sep 24 '22 11:09 mlee12382

"convinced that E0_AUTO_FAN_PIN is set to FAN_PIN when it's not. " This was a bug, fixed in https://github.com/MarlinFirmware/Marlin/pull/24593/files

ellensp avatar Sep 24 '22 11:09 ellensp

"convinced that E0_AUTO_FAN_PIN is set to FAN_PIN when it's not. " This was a bug, fixed in https://github.com/MarlinFirmware/Marlin/pull/24593/files

I will update my marlin source and try again, I did update fairly recently though and it was still an issue, but will try again just in case.

mlee12382 avatar Sep 24 '22 11:09 mlee12382

"convinced that E0_AUTO_FAN_PIN is set to FAN_PIN when it's not. " This was a bug, fixed in https://github.com/MarlinFirmware/Marlin/pull/24593/files

Unfortunately even updating to the current 2.1.x bugfix files I am still getting the same error. :(

mlee12382 avatar Sep 24 '22 21:09 mlee12382