MarlinFirmware
Added HICTOP 3DP-17
Thanks for the submission! New configurations must be based on the default configurations from import-2.1.x for inclusion in the next release. The configurations in this PR are targeted to an older version of Marlin, so they will need to be updated to the current version, 02010300 .
I went ahead and applied the needed updates. Please check to make sure they still work as intended and have all the same changes. One quick way to see all the changes in isolation is to replace the Hictop configs with the default configs, then use GitHub Desktop to view the differences.
line 1601 should read
#define NOZZLE_TO_PROBE_OFFSET { 10, 50, -1}
I have tried to build the firmware but get error for the code between lines 3212->3215
//#define DGUS_LCD_UI ORIGIN
#if DGUS_UI_IS(MKS)
#define USE_MKS_GREEN_UI
#elif DGUS_UI_IS(IA_CREALITY)
I am using PlaformIO in visual studio code to build the firmware
I have tried to build the firmware but get error for the code between lines 3212->3215
What's the error? Make sure you're using the latest bugfix-2.1.x.
All changed configs in a PR are built and this PR passed:
Thanks for your advice, build and tested on my 3D printer
I assume you closed this PR on accident, so I’ve reopened it.
How’d testing go?
I seen someone comment PlaformIO studio. I'm trying to figure out how to use the system.
I did that thank you
On Fri, Sep 27, 2024, 5:07 PM Scott Lahteine @.***> wrote:
Merged #1064 https://github.com/MarlinFirmware/Configurations/pull/1064 into import-2.1.x.
— Reply to this email directly, view it on GitHub https://github.com/MarlinFirmware/Configurations/pull/1064#event-14436294462, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLOSAHMBLD4LLO4ZP7XZWU3ZYXCHLAVCNFSM6AAAAABJAVPEXCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQZTMMRZGQ2DMMQ . You are receiving this because you commented.Message ID: @.*** com>
Sorry it's been a very long time since I was able to get back I kind of forgot and just never got back on but I'm back now and I did do those two configures I went back and I looked and they were already configured.