Configurations icon indicating copy to clipboard operation
Configurations copied to clipboard

🔥 Remove DISKIO_HOST_DRIVE

Open thisiskeithb opened this issue 10 months ago • 3 comments

Description

Since https://github.com/MarlinFirmware/Marlin/pull/19939 was closed & never merged, remove DISKIO_HOST_DRIVE option.

Benefits

Removes dead config option

Related Issues

  • https://github.com/MarlinFirmware/Marlin/pull/19939

thisiskeithb avatar Mar 28 '24 13:03 thisiskeithb

CI will fail due to a handful of Geeetech configs that still won't build correctly due to some LCD/library incompatibilities after https://github.com/MarlinFirmware/Marlin/commit/ec7ab5a277a0210e1349f9e8608c372e40fdb6e6.

thisiskeithb avatar Mar 28 '24 13:03 thisiskeithb

...PR fixed after recent force-pushes to import-2.1.x, but my comment above is still applicable.

thisiskeithb avatar Apr 01 '24 02:04 thisiskeithb

Rebased on current import-2.1.x and I've removed this code from the recently added configs.

thisiskeithb avatar May 02 '24 00:05 thisiskeithb

CI will fail due to a handful of Geeetech configs that still won't build correctly due to some LCD/library incompatibilities after MarlinFirmware/Marlin@ec7ab5a.

... and apparently some other recent changes:

HEAD is now at f5cf667c95 🎨 Clarify some string parameters (#26949)
Building Configurations in config/examples/CNC/miniRambo ...
Building environment rambo for board MINIRAMBO (1201)...

In file included from Marlin/src/gcode/feature/digipot/../../../inc/MarlinConfigPre.h:37:0,
                 from Marlin/src/gcode/feature/digipot/../../../inc/MarlinConfig.h:28,
                 from Marlin/src/gcode/feature/digipot/M907-M910.cpp:23:
Marlin/src/gcode/feature/digipot/M907-M910.cpp: In static member function 'static void GcodeSuite::M907_report(bool)':
Marlin/src/gcode/feature/digipot/M907-M910.cpp:137:13: error: 'SP_E_STR' was not declared in this scope
           , SP_E_STR,       stepper.motor_current_setting[2]  // E
             ^

Edit: This CNC config was committed directly so it was not checked by CI: e7254f1

thisiskeithb avatar May 08 '24 17:05 thisiskeithb