MarkusRost

Results 82 comments of MarkusRost

Setting the `skin-theme-clientpref-os` class on the `` element in vector-2022 might already be able to add darkmode for Wikipedia. I'm just not sure if this will create conflicts with wikis...

> That's a JS-based solution, whereas what we are being encouraged to support in readers is a pure CSS solution that looks like: There are a multitude of different JS,...

> Problem is, it's really bad UX to have a toggle saying "Always use dark theme", but it doesn't work for the great majority of ZIMs. The CSS media feature...

> > Setting the `skin-theme-clientpref-os` class on the `` element in vector-2022 might already be able to add darkmode for Wikipedia. I'm just not sure if this will create conflicts...

> Looks like we are missing the `ext.wikimediamessages.styles` CSS module. I have created an upstream issue about the module missing from the API output. Once that is fixed, we should...

> I feel like we could hence technically have a ZIM with a mix of articles with support for night mode, and other articles which don't support it. That should...

I was actually already looking at this, and once we have #2310 even with a limited module list, we could fully support the vector-2022 cookie based client preferences. That's the...

> Postponing to 2.0, we are not aware of any occurrence where these JS scripts are missing for now. Does the hardcoded hack introduced in #1701 count as an occurrence...

I have been looking into how to best solve this issue, and while we can't fix the loading of external content or api requests some scripts might attempt, we should...

We should absolute keep the CSS modules directly in the HTML. `RLSTATE` just lets the ResourceLoader know which modules we have already loaded, so that it won't attempt to load...