Inchoo_SocialConnect icon indicating copy to clipboard operation
Inchoo_SocialConnect copied to clipboard

Published 20 hours ago • verified publisher icon Marko-M

Any reason you have not included DOB and Gender for FB login?

Open mobweb opened this issue 9 years ago • 2 comments

I've added these fields and I didn't notice any problems, they get imported perfectly. The parameters are included in the data provided by FB anyway, so why not include it when creating an account?

I can send a PR but I'm wondering if perhaps you have left this out intentionally as there is some issue there that I'm not seeing...

mobweb avatar Oct 24 '14 13:10 mobweb

Hi @mobweb, no issues, actually I have this added to Social Connect at one project and it works very well. It's simply matter of time because Social Connect is a pet project of mine, and I try to maintain the core but never got around to polish things like additional fields.

It will be done eventually, but if you have the code you can submit pull request, I'll merge it with what I already have, and we'll have that simple thing in mainline code ;)

Regards, Marko

Marko-M avatar Oct 24 '14 13:10 Marko-M

OK, I just submitted a PR (https://github.com/Marko-M/Inchoo_SocialConnect/pull/22), hope you can use it.

By the way thanks for this awesome extension, saved me a ton of time today! :)

mobweb avatar Oct 24 '14 20:10 mobweb