nft-marketplace icon indicating copy to clipboard operation
nft-marketplace copied to clipboard

createMarketSale have nftContractAddress as argument

Open ghettoaliens opened this issue 2 years ago • 1 comments

Hello, first of all thank you very much for contributing with a marketplace code that people can use as an example.

And secondly, i think that the createMarketSale would have to get the contract address directly from the mapping array marketItemIdToMarketItem not as a function argument.

Because it could allow an external user to shop a token through a different contract address, not the address of the market item.

ghettoaliens avatar Jul 02 '22 19:07 ghettoaliens

Hey, @ghettoaliens! You're right, this improvement would give this contract greater versatility. I might add this feature when I have time, but would you like to open a Pull Request with it?

Markkop avatar Jul 06 '22 01:07 Markkop