robotframework-browser icon indicating copy to clipboard operation
robotframework-browser copied to clipboard

Presenter mode question

Open otemek opened this issue 9 months ago • 7 comments

Hi

I'm curious why hardcoded 5 seconds sleep is implemented under _end_test method (only here and only for AutoClosingLevel == TEST) when presenter mode is enabled. Is there any reason why there is a wait here - if so, then maybe it could be parameterized?

Thanks in advance for info.

otemek avatar Mar 03 '25 09:03 otemek

I guess it is there because we want to show the presenter mode for 5s. Mikko made, so he is the only one to know for sure, but I think that is the reason. May I ask why you are curious?

aaltat avatar Mar 07 '25 18:03 aaltat

I'm asking cause I used the presenter mode to show some automation for a business audience and they were wondering why it's running so slow... so 5 seconds was way too much for my audience, except that this mode is brilliant with possibilty to highlight elements. Besides that...it's only applicable for auto closing level == test, e.g. and not for suite. Imho if that's the intention to slow down things for 5 seconds, than am OK with that, otherwise maybe someone put it temporarily, etc. and at the end forgot about that. :)

otemek avatar Mar 07 '25 18:03 otemek

I was looking at the same thing. I will considered it as bug, because it should work same way for suites too. I need to look code more closely and test it out.

@allcontributors please add @otemek for bugs.

aaltat avatar Mar 07 '25 18:03 aaltat

@aaltat

I've put up a pull request to add @way! :tada:

allcontributors[bot] avatar Mar 07 '25 18:03 allcontributors[bot]

Hmmm, interesting allcontributors did create PR for wrong user. Reported it https://github.com/all-contributors/all-contributors/issues/817

aaltat avatar Mar 09 '25 14:03 aaltat

@allcontributors please add @otemek for bugs.

aaltat avatar Mar 23 '25 21:03 aaltat

@aaltat

I've put up a pull request to add @otemek! :tada:

allcontributors[bot] avatar Mar 23 '25 21:03 allcontributors[bot]