robotframework-browser icon indicating copy to clipboard operation
robotframework-browser copied to clipboard

Remove the "tips" on selector errors

Open simonmeggle opened this issue 1 year ago • 4 comments

I want to discuss the sense of these “tips” wich always come up on a selector error:

Tip: Use Set Browser Timeout for increasing the timeout or double check your locator as the targeted element(s) couldnt be found.

I think everybody which works with Browser lib for some time has seen this message multiple times - but always takes an decision based on his own judgement and not on what the library proposes. If, for example, a timeout is exceeded when loading a page, the error message Timeout 10000ms exceeded reads accordingly. This is enough to know what happened.

Increasing the timeout can be a solution to the problem. Also a wrong locator can be a solution, yes. But other problems (not mentioned in the tip) are at least as likely.


I already posted in Slack some time ago. But right now I got a request from a customer to "increase the timeout" in a failed test. Looking closer I saw that the page had a problem and the selector was not found. This is exactly what I mean: these "Tips" lead to false assumptions, especially on untrained staff.

simonmeggle avatar Apr 19 '24 08:04 simonmeggle

@Snooz82 what you think about the proposal?

aaltat avatar May 02 '24 18:05 aaltat

@aaltat i am fine with the proposal to streamline the error. and remove the tips!

Snooz82 avatar May 02 '24 19:05 Snooz82

@allcontributors please add @simonmeggle for ideas

aaltat avatar May 02 '24 20:05 aaltat

@aaltat

@simonmeggle already contributed before to ideas

allcontributors[bot] avatar May 02 '24 20:05 allcontributors[bot]

I will also remove the ANSI colors from the Playwright error messages.

Snooz82 avatar Oct 07 '24 08:10 Snooz82