Sylvan.Data.Excel icon indicating copy to clipboard operation
Sylvan.Data.Excel copied to clipboard

Feature request: add option to read hidden rows

Open 0xced opened this issue 1 year ago • 3 comments

The ExcelDataReaderOptions already has the ReadHiddenWorksheets option. It would be nice to also have a ReadHiddenRows option. It should default to true in order not to break compatibility with existing code.

0xced avatar Sep 23 '24 07:09 0xced

Would probably make sense to also allow skipping hidden columns.

MarkPflug avatar Sep 24 '24 00:09 MarkPflug

Absolutely! Should probably be ReadHiddenCells instead of ReadHiddenRows. Would you be interested in a pull request?

0xced avatar Sep 25 '24 06:09 0xced

No PR needed. I think I have it working for .xlsx, just need to add the other formats and add some test coverage.

MarkPflug avatar Sep 26 '24 18:09 MarkPflug

Finally implemented in 0.4.28. Added ReadHiddenRows, but not ReadHiddenColumns, which can be easily achieved by using the DbDataReader.Select extension method provided in Sylvan.Data

MarkPflug avatar Jul 23 '25 17:07 MarkPflug