MarkMageeAstro
MarkMageeAstro
@yuyizheng1112, can you provide more information on the tests? Does making this change still behave as expected? I haven't run the code myself. @jamesgillanders, I suppose it would go here...
Hi @jayantbhakar, what's the issue you're running into?
There may have been some changes to some of the properties you were tracking due to the ongoing restructure work. What are the conflicts you're finding?
Hmm, I'm not very familiar with the tests, but it looks like it's something to do with the atomic data. Maybe it's changed? @andrewfullard might know
Any luck with this @AyushiDaksh?
@AyushiDaksh can you let us know if you're still interested in this?
> @MarkMageeAstro > > > One minor correction to documentation. > > Somehow I'm not able to see your comment. Can you point me to where you need the correction?...
Looks good to me and also works on my local install. Thanks @AyushiDaksh!
Maybe someone else knows, but is 'hv' or 'vh' correct? Each shell is defined by an inner and outer velocity, so does the temperature, etc. correspond to the inner or...
Maybe I'm over thinking it or confusing myself (both are very real possibilities). The code has changed quite a bit since I last looked at it, I think. It looked...