Mark Daoust

Results 254 comments of Mark Daoust

https://github.com/google-gemini/generative-ai-python/pull/275

Also, se can't merge anything until you sign the CLA.

On tensorflow we've been [running doctest](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/docs/tf_doctest_lib.py) but it expects the `>>>` format. For TensorFlow we went with the default `>>>` because that way we could easily distinguish between working and...

I was just planning on "eventual consistency", let's not make this more complicated than it needs to be.

@sakher, you do have a point, `hasattr(parts[0], "text")` would be more robust here. But the problem is that `"text" in parts[0]` is supposed to work for the proto-plus based proto...

I think this is the fix we need: https://github.com/googleapis/proto-plus-python/pull/471

Google's Vertex-AI Just launched this, hopefully that means it's coming soon here, but I don't have a timeline.