markbind icon indicating copy to clipboard operation
markbind copied to clipboard

Follow-up: Improve DangerJS Coupling Check

Open gerteck opened this issue 4 months ago • 0 comments

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

#2742, #2523

What is the area that this feature belongs to?

Testing

Is your feature request related to a problem? Please describe.

Background

The DangerJS workflow (original -> #2523), (refactor -> #2742, #2708) currently:

  • Runs on every pull_request.
  • Logs coupling violations between implementation, test, and documentation files in CI logs.
  • Does not fail the check.
  • Uses console logging (logger dependency has been removed).
  • dangerfile.ts is already in a subdirectory (scripts/).

While the check works, there are opportunities for improvement:

  • Developers may miss errors in CI logs since the check does not fail PRs.

Describe the solution you'd like

Goals

  1. Track accuracy of coupling detection

    • Evaluate current detection accuracy.
    • Identify false positives/negatives.
    • Once reliable, consider failing PRs on violations using Danger.fail.
  2. Improve DangerJS integration

    • Use Danger API (warn, fail, message, info) appropriately.
    • Decide whether coupling issues should be warnings or block the PR.

Notes

  • Incremental improvement is acceptable: focus first on tracking accuracy and proper Danger API usage.
  • Developers may not currently notice warnings due to logging in CI only.

Describe alternatives you've considered

No response

Additional context

No response

gerteck avatar Aug 31 '25 03:08 gerteck