markbind icon indicating copy to clipboard operation
markbind copied to clipboard

Popover error message

Open Golddirio opened this issue 4 months ago • 1 comments

What is the purpose of this pull request?

  • [ ] Documentation update
  • [x] Bug fix
  • [x] Feature addition or enhancement
  • [ ] Code maintenance
  • [ ] DevOps
  • [ ] Improve developer experience
  • [ ] Others, please explain:

Fixes #2688

Overview of changes: Popover error messages are placed in the content position which is consistent right now.

Anything you'd like to highlight/discuss: Now the error messages are shown below: Screenshot 2025-07-28 210239 Screenshot 2025-07-28 210244

Testing instructions: NA

Proposed commit message: (wrap lines at 72 characters) Fix the inconsistency in positions of popover error messages


Checklist: :ballot_box_with_check:

  • [ ] Updated the documentation for feature additions and enhancements
  • [ ] Added tests for bug fixes or features
  • [x] Linked all related issues
  • [ ] No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • [ ] Major (when you make incompatible API changes)
  • [ ] Minor (when you add functionality in a backward compatible manner)
  • [ ] Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Golddirio avatar Jul 28 '25 13:07 Golddirio

Hi @Golddirio,

just a preliminary test, will give a more detailed PR review. I noticed that the popover error message no longer shows for URLs in your branch, see:

image

gerteck avatar Aug 04 '25 06:08 gerteck