MarkBind
Close button covers page
Please confirm that you have searched existing issues in the repo
Yes, I have searched the existing issues
Any related issues?
No response
Tell us about your environment
MacOS Sequoia
MarkBind version
5.6.0
Describe the bug and the steps to reproduce it
https://github.com/user-attachments/assets/6d431fca-213a-4612-bb2f-8cd78706d500
Activity diagram Basic at https://nus-cs2103-ay2425s2.github.io/website/se-book-adapted/chapters/modeling.html has the closing button covering the content
Expected behavior
for it to not cover the content, maybe appear at the right side or the original words should shift to the right
Anything else?
No response
Hi @GrassHeadd, thank you for raising the issue!
The closing button is the feature of the custom vue directive that enables users to close / minimize elements for better viewability while navigating pages. It is an overlay positioned absolutely at the top left of the element, it currently overlaps the content slightly.
- Note that this would make it hard to cause an expected behavior of shifting the content within the element, since it is an overlay.
https://github.com/MarkBind/markbind/blob/9c33eb47c4c4e79f1a97b1acc4173aa53fcff195/packages/vue-components/src/directives/Closeable.js#L1-L69
Given that the close button only appears when the cursor is hovering over the element, and that it is designed to be small and unobtrusive, I believe it generally does not interfere significantly with content readability. However, in cases like the activity diagram where the content is dense and important, I suppose it could be improved.
We could consider adding some repositioning options for the button (e.g., top-right) or adding padding/margin to shift the content slightly to avoid being covered when hovered etc. Depending on discussion and further input with the team, we could look into this issue, or close the issue if it is deemed less of a priority.
Thanks again for the feedback and contribution! — I also recommend you look into our list of issues if you would like to contribute!
Hi @pinion05, thanks for your eagerness to contribute!
I recommend checking out our list of open issues and picking one that you feel comfortable and interested in tackling. You can comment on the issue to let us know!
Also, please keep communications in English so that everyone in the community can follow along. Thank you!