markbind icon indicating copy to clipboard operation
markbind copied to clipboard

Add note on netlify config when migrating Node.js

Open yucheng11122017 opened this issue 1 year ago • 2 comments

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

What is the area that this feature belongs to?

No response

Is your feature request related to a problem? Please describe.

It would be helpful to new developers to have instructions on how to migrate in the DG similiar to 'Migrating to Typescript'.

Describe the solution you'd like

Include checklist and steps needed for migrating in DG.

This can take reference from what was done in #2233 when migrating to node v16 from v14

Left with one TODO:

  • [ ] After #2277, the netlify setting for deploying our documentation on markbind-master is configured using the netlify.toml in our root folder. When migrating, we should change the Node.js version specified in that file accordingly. Hence, we should mention this step in the migrating to Node.js docs

Describe alternatives you've considered

No response

Additional context

No response

yucheng11122017 avatar Mar 28 '23 09:03 yucheng11122017

Hi @yucheng11122017, just checking, is this closed by #2256? Is there anything else that we should add to our DG related to Node.js migration?

jovyntls avatar Apr 15 '23 13:04 jovyntls

@jovyntls I think so, but I realized I accidentally introduced a place that needs updating the docs for (https://github.com/MarkBind/markbind/pull/2277). Will modify and make use of this issue for that.

tlylt avatar Apr 15 '23 14:04 tlylt