Mark Hamstra

Results 75 issues of Mark Hamstra

Let's say you want to fix the typo, you'll have to type the full name again first. ![schermafbeelding 2017-08-15 om 14 19 05](https://user-images.githubusercontent.com/312944/29315683-bf6b1bbc-81c4-11e7-9d1c-ff7079153804.jpg)

This was fixed before (#37?) but seems to have returned. Wiping localstorage makes it request files/folders for media source 0 instead of the ones in the response from the api.

While the readme isn't clear about what is and what isn't expected behaviour, I landed on the following code to check if a customer id exists: ```php $id = '...';...

https://modx.pro/hosting/23448 ([automatic translation](https://modx-pro.translate.goog/hosting/23448?_x_tr_sl=auto&_x_tr_tl=en&_x_tr_hl=en&_x_tr_pto=wapp)) Perhaps there's some inspiration or opportunity to collaborate https://github.com/bezumkin/modx-docker

Would be nice to use the allow the template picker to be used for creating collection children. Probably should be optional as for some containers you'll want it to always...

In the [MODX deprecations issue](https://github.com/modxcms/revolution/issues/13199) there's the question of toJSON and fromJSON utilities, and wether that's still necessary or should be removed. I'd say deprecating them would be a pretty...

In https://github.com/modxcms/xpdo/blob/3.x/src/xPDO/xPDO.php#L474-L476, changing `$added = true;` to `$added = $this->setPackageMeta` will allow calls to `addPackage` to get the proper true/false dependant on the actual success.

bug
priority-2-high

First pass at implementing support for a PSR-3 logger into xPDO. The basic idea is you pass a `LoggerInterface` into the container, which will then be set to `protected xPDO::$logger`...

cla-signed

Given a model class like.. ``` namespace Namespace\Model; class SomeObject extends xPDOObject { protected const SOME_CONSTANT = 'some relevant value'; ``` ... the created platform classes get: ``` namespace Namespace\Model\mysql;...

Force the chosen charset instead of relying on unreliable server behavior.