PullUpController icon indicating copy to clipboard operation
PullUpController copied to clipboard

Cannot embed pullupcontroller within tab bar view

Open hxsseeb opened this issue 4 years ago • 8 comments

Contacted you on twitter have a replicated example on me, when a tab bar view is embed into the main view the pullupcontroller is hidden under the tab bar on the iPhone X, Xr, Xs and Xs Max

hxsseeb avatar Sep 02 '19 20:09 hxsseeb

Hello @hxsseeb could you please attach the example project here?

MarioIannotta avatar Sep 02 '19 20:09 MarioIannotta

Uploading PullUpController With ISSUE.zip…

hxsseeb avatar Sep 02 '19 21:09 hxsseeb

I think you didn't wait for the upload to finish, can you please double check?

MarioIannotta avatar Sep 02 '19 21:09 MarioIannotta

hey man. any luck?

hxsseeb avatar Sep 04 '19 19:09 hxsseeb

Hey I did a little investigation and the problem is that the space of the bottom bar is never take into account in the calculations. eg: this line

I'm not planning to fixing that because it need too much time and the outcome would be not so good in terms of user experience.

Please consider to use the component in a controller where no other components are involved at the bottom of the screen.

MarioIannotta avatar Sep 05 '19 15:09 MarioIannotta

I see. Thank you none the less for looking into the issue.

One other problem is that the PullUpController does not begin from the bottom of the screen on the iPhone X, Xr and Xs variants.

How can this be solved?

Apologies if I'm asking a lot of questions, I am new to Swift programming and just really want to implement your pod into my project.

Photo below:

IMG_8ABBDFC5665D-1

hxsseeb avatar Sep 05 '19 16:09 hxsseeb

No worries at all :) https://github.com/MarioIannotta/PullUpController/issues/57 here there's a solution for the issue you're reporting, let me know if it works for you.

MarioIannotta avatar Sep 05 '19 21:09 MarioIannotta