Landscape Orientation not working properly

[qasimmajeed]

I am implementing pullupcontroller in iPad with landscape and portrait orientations.but I just found the landscape is not working fine even i am unable to close the pullupcontroller to its initial point.Kindly can you help me in this one

[CfiedlerIII]

@qasimmajeed Are you having trouble closing the PullUpController, or having trouble dragging the PullUpController down to the bottom? I don't have issues closing the PullUpController altogether while in landscape, but I do have issues where the PullUpController won't drag up or down even though I verified that I have stickyPoints set.

[MarioIannotta]

Hi @CfiedlerIII thanks for this great work! Instead of making a new library from this (where everything has been renamed hence keeping the changes in sync would be hard), I would love to add your improvements to this pod.

Could you please make a PR? I don't mind major changes as long as don't cause regressions. Note that, for example, you removed the UIScrollView extension that was the only way to set the internal scroll view; did you test also this case?

Thanks, Mario

[CfiedlerIII]

Hi, My changes didn't require removing the scrollview or renaming all of the variables, my use case for the pod was just slightly more simple and contained a tableview that takes care of the scrolling automatically, so I pulled out the code I didn't need. I'll try and recreate the work I did yesterday and make a PR which ONLY makes the landscape controller draggable. Thanks for doing all the hard work with the animation, since that's the thing I'm still pretty new to.

Glad to help, Chase Fiedler

On Thu, May 30, 2019 at 12:11 AM Mario Iannotta [email protected] wrote:

Hi @CfiedlerIII https://github.com/CfiedlerIII thanks for this great work! Instead of making a new library from this (where everything has been renamed hence keeping the changes in sync would be hard), I would love to add your improvements to this pod.

Could you please make a PR? I don't mind major changes as long as don't cause regressions. Note that, for example, you removed the UIScrollView extension that was the only way to set the internal scroll view; did you test also this case?

Thanks, Mario

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarioIannotta/PullUpController/issues/59?email_source=notifications&email_token=AB6LDAPIUWH6R5OZ4RHFUTTPX542DA5CNFSM4HNQLFQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRSCOQ#issuecomment-497230138, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6LDAO6NNSMYLR3BOJ3P6TPX542DANCNFSM4HNQLFQA .

[CfiedlerIII]

I know that the original intention for this pod was to copy what apple maps did, so there's a few points I think I need to get straight as to where the controller should appear in landscape mode. Regardless, here's a link to a video of landscape and portrait working with minimal changes in your project. I don't have permissions at the moment to create a working branch and make a pr.

Let me know your thoughts. https://photos.app.goo.gl/VExDejTizg3F2pky7

Chase Fiedler

On Thu, May 30, 2019 at 9:07 AM Chase Fiedler [email protected] wrote:

Hi, My changes didn't require removing the scrollview or renaming all of the variables, my use case for the pod was just slightly more simple and contained a tableview that takes care of the scrolling automatically, so I pulled out the code I didn't need. I'll try and recreate the work I did yesterday and make a PR which ONLY makes the landscape controller draggable. Thanks for doing all the hard work with the animation, since that's the thing I'm still pretty new to.

Glad to help, Chase Fiedler

On Thu, May 30, 2019 at 12:11 AM Mario Iannotta [email protected] wrote:

Hi @CfiedlerIII https://github.com/CfiedlerIII thanks for this great work! Instead of making a new library from this (where everything has been renamed hence keeping the changes in sync would be hard), I would love to add your improvements to this pod.

Could you please make a PR? I don't mind major changes as long as don't cause regressions. Note that, for example, you removed the UIScrollView extension that was the only way to set the internal scroll view; did you test also this case?

Thanks, Mario

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarioIannotta/PullUpController/issues/59?email_source=notifications&email_token=AB6LDAPIUWH6R5OZ4RHFUTTPX542DA5CNFSM4HNQLFQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRSCOQ#issuecomment-497230138, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6LDAO6NNSMYLR3BOJ3P6TPX542DANCNFSM4HNQLFQA .

[MarioIannotta]

Do you think that it would be possible to keep both behaviors? We could model it with a simple enum with associated values.

enum LandscapeMode {
  case fixed(frame: CGRect)
  case pullable(stickyPoints: [CGPoint])
}

What do you think?

[CfiedlerIII]

That could probably work. I hadn't thought of that.

On Fri, May 31, 2019, 3:02 AM Mario Iannotta [email protected] wrote:

Do you think that it would be possible to keep both behaviors? We could model it with a simple enum with associated values.

enum LandscapeMode { case fixed(frame: CGRect) case pullable(stickyPoints: [CGPoint]) }

What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarioIannotta/PullUpController/issues/59?email_source=notifications&email_token=AB6LDAIWHCG53UJYHIVQWMDPYDZTLA5CNFSM4HNQLFQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUZRFA#issuecomment-497653908, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6LDAJII2S3YXJDOELVT2TPYDZTLANCNFSM4HNQLFQA .