csla icon indicating copy to clipboard operation
csla copied to clipboard

Breaking change: Blazor StateManager does not use the provided timeout parameter

Open luizfbicalho opened this issue 9 months ago • 6 comments

The previous PR had a merge problem

Closes #3800

luizfbicalho avatar May 03 '24 22:05 luizfbicalho

@luizfbicalho agreed - see #3911

luizfbicalho avatar May 03 '24 22:05 luizfbicalho

@rockfordlhotka can we finish this one first and then we proceed with the other changes? this way I can estimate all the interfaces and inplementations beforehand and create a new milestone?

luizfbicalho avatar May 04 '24 00:05 luizfbicalho

I think that is a wise course of action, yes.

rockfordlhotka avatar May 04 '24 00:05 rockfordlhotka

@luizfbicalho Did you send a contributor agreement to rocky? I'll mark the PR as "missing agreement" until I hear from rocky or he removes the tag.

Edit: You are a member of the csla developers so I think the agreement is there. 👍

StefanOssendorf avatar May 04 '24 14:05 StefanOssendorf

@luizfbicalho Did you send a contributor agreement to rocky? I'll mark the PR as "missing agreement" until I hear from rocky or he removes the tag.

Edit: You are a member of the csla developers so I think the agreement is there. 👍

I sent to him, do you want me to send a copy?

luizfbicalho avatar May 04 '24 14:05 luizfbicalho

@luizfbicalho Did you send a contributor agreement to rocky? I'll mark the PR as "missing agreement" until I hear from rocky or he removes the tag. Edit: You are a member of the csla developers so I think the agreement is there. 👍

I sent to him, do you want me to send a copy?

No, all good. I found the place where to look for if an agreement was submitted or not :)

StefanOssendorf avatar May 04 '24 17:05 StefanOssendorf

Sorry for the delay and thank you for your patience.

LGTM :-)

StefanOssendorf avatar May 09 '24 18:05 StefanOssendorf