csla icon indicating copy to clipboard operation
csla copied to clipboard

WPFUi should use appsettings.json for DataPortal URL

Open BlagoCuljak opened this issue 5 years ago • 9 comments

To get better jumpstart on CSLA using WPF Ui, I have made adjustments to ProjectTracker where WPFUi is using appsettings.json.

Hope to do the same for Blazor Client, but maybe it's better to wait for final release.

If it's ok, and I have the right to do so, I would make an Pull request.

BlagoCuljak avatar Apr 03 '20 06:04 BlagoCuljak

@BlagoCuljak this new set of changes (https://github.com/MarimerLLC/csla/issues/1548) will impact your PR I think.

rockfordlhotka avatar Apr 09 '20 19:04 rockfordlhotka

We can undo it, if we're about to have more issues.

Didn't look too much into the issue, I'm on mobile app.

BlagoCuljak avatar Apr 09 '20 19:04 BlagoCuljak

@BlagoCuljak Do you want to revisit this now that the dust has settled on the other changes around DI and app initialization?

I do think having config values read correctly would be a great step forward!

rockfordlhotka avatar Apr 30 '20 18:04 rockfordlhotka

Sure, what do you propose? That we scrap these changes in favor of #1548?

BlagoCuljak avatar Apr 30 '20 18:04 BlagoCuljak

Merge your reading of the config file/settings into the new (current) app config code.

https://github.com/MarimerLLC/csla/blob/master/Samples/ProjectTracker/ProjectTracker.Ui.WPF/App.xaml.cs

rockfordlhotka avatar Apr 30 '20 18:04 rockfordlhotka

Dude, you always get me on some holiday. 😀 First Easter, now Labour day. If you don't want to wait for next week, could you please do it yourself? Thanks

BlagoCuljak avatar Apr 30 '20 18:04 BlagoCuljak

There's no rush, I was just wondering if you remained interested in working on this.

rockfordlhotka avatar Apr 30 '20 18:04 rockfordlhotka

Rocky, could you do the merge, please? I'm having issues that prevent me from doing so, sorry.

BlagoCuljak avatar May 06 '20 18:05 BlagoCuljak

You mean for the original PR?

https://github.com/MarimerLLC/csla/pull/1543

I think the problem is that PR changed files (mostly Program.cs) that have been radically altered since the PR was created. It may not be possible to merge at this point.

It is almost certainly easier to take the current Program.cs, which uses the new UsingCsla method coming in 5.2.0, and add the code to read the config settings using the standard .NET config subsystem.

rockfordlhotka avatar May 06 '20 20:05 rockfordlhotka

No longer relevant with modern .NET and CSLA.

rockfordlhotka avatar Feb 23 '24 21:02 rockfordlhotka