Maria José Solano
Maria José Solano
@amaanq I'll be glad to once I know what the right instructions are :)
> The policy regarding lua typings (is a specific type like `fun(dispatchers: Dispatchers): StartServer?` prefered over a general one like `function`? There's nothing written in stone about it, but _personally_...
> @MariaSolOs Do you have any other inputs on this? Otherwise I'd go ahead and merge this. We can still follow up with renaming the method before it get's released....
> > I’m not in favor of adding workarounds for misbehaving servers, unless there is a _very_ compelling reason. > > As a project we generally adhere to the position...
Not blocking for this PR, but I created https://github.com/microsoft/language-server-protocol/issues/1882 to make sure all LSP editors have a consistent behaviour around this.
Okay the implementation is done and tests are all passing. At this point we just need to agree on whether we should enable completion by default and the structure of...
> I'd suggest to go with the enable / is_enabled. That also gives us the option to add configuration options to the enable call. @mfussenegger got it, that sounds reasonable....
> I'd suggest to go with the `enable` / `is_enabled`. @mfussenegger what would `is_enabled` be used for?
> It's optional, but the typical use-case is to "toggle". And any other (presumed) use-case where scripts want to decide behavior based on whether a feature is enabled. @justinmk Right,...
We would also need to add [the client capability](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#documentRangeFormattingClientCapabilities) here: https://github.com/neovim/neovim/blob/2e982f1aad9f1a03562b7a451d642f76b04c37cb/runtime/lua/vim/lsp/protocol.lua#L742