server icon indicating copy to clipboard operation
server copied to clipboard

`rpl_start`/`stop_server.inc` fixes

Open ParadoxV5 opened this issue 9 months ago • 1 comments
trafficstars

  • ~~The Jira issue number for this PR is: MDEV-______~~

Description

  • rpl_stop_server.inc: re. “can’t use begin/end_include_file”, (re)define $_include_file_depth= 0 in case this is the first --source in a rpl_init.inc-less setup (e.g., multi_source.*)
  • rpl_start_server.inc: move the end_include_file.inc call out of if (!$rpl_server_error) to always close the begin_include_file.inc
  • rpl_reconnect.inc (called by rpl_start_server.inc): skip reconnecting ‘master/slave’ aliases of server_*to lift its practical requirement ofmaster-slave.inc(It failed with “no connection named master/slave” for even arpl_init.incsetup, let alonerpl_init`-less.)

Release Notes

Do our users even use our include/*.incs?

How can this PR be tested?

  • [ ] Do we need a test for a test?

PR quality check

  • [ ] This is a new feature or a refactoring, and the PR is based against the main branch.
  • [x] This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.
  • [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

ParadoxV5 avatar Feb 21 '25 05:02 ParadoxV5