server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-33952: Fix flaky galera_create_table_as_select test with debug sync

Open denis-protivensky opened this issue 9 months ago • 1 comments

  • [x] The Jira issue number for this PR is: MDEV-33952

Description

The test that triggers multi-master conflict between two CTAS commands uses LOCK/UNLOCK TABLES to block local CTAS from progress. It could result in a race when UNLOCK TABLES command is issued a bit earlier then needed, causing local CTAS to run further and change wsrep transaction state, so that a different code path is taken later and the original error gets overridden, causing the test to fail. The solution is to replace LOCK/UNLOCK TABLES with debug sync points.

Release Notes

The fix is for 10.5+ versions.

How can this PR be tested?

MTR test is fixed an re-enabled.

Basing the PR against the correct MariaDB version

  • [ ] This is a new feature and the PR is based against the latest MariaDB development branch.
  • [x] This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

denis-protivensky avatar May 08 '24 11:05 denis-protivensky

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 08 '24 11:05 CLAassistant

Thanks, the fix has been merged with the head revision: https://github.com/MariaDB/server/commit/a6b7203d6564728089df66231739e0cc77b039d7

sysprg avatar Jun 04 '24 02:06 sysprg