server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-33919: Remove less standard format directive an-trap

Open illuusio opened this issue 10 months ago • 2 comments

  • [x] The Jira issue number for this PR is: MDEV-33919

Description

Few man pages have less standard format directive: .it 1 an-trap which specifying a formatting instruction related to indentation (adds tab in man page in this)

There is no traces what an-trap should do and removing it does not affect rendering of man page

Release Notes

There should be any mention this on release notes

How can this PR be tested?

One can render these man pages as ascii with

groff -man -Tascii man/mysqlbinlog.1
groff -man -Tascii man/mysqldump.1
groff -man -Tascii man/mysqladmin.1
groff -man -Tascii man/mysqlcheck.1
groff -man -Tascii man/myisamchk.1
groff -man -Tascii man/mysqld_safe.1
groff -man -Tascii man/mysql_upgrade.1

Diff old and new should be the same

Basing the PR against the correct MariaDB version

  • [x] This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

illuusio avatar Apr 16 '24 07:04 illuusio

Couldn't find too much online regarding the "an-trap" directive. If there's not much documentation on why it is there and there is no functional difference between the output I think it is a good idea to just remove it to avoid confusion.

anson1014 avatar Apr 23 '24 18:04 anson1014

Couldn't find too much online regarding the "an-trap" directive. If there's not much documentation on why it is there and there is no functional difference between the output I think it is a good idea to just remove it to avoid confusion.

This was kind of my 'motivation'. I could no find any traces why it should be there and it renders the same.

illuusio avatar Apr 29 '24 05:04 illuusio