server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-12404: Add assertions about Index Condition Pushdown use

Open spetrunia opened this issue 3 months ago • 1 comments

Add assertions about limitations one has when using Index Condition Pushdown:

  • add handler::assert_icp_limitations()
  • call this function from functions that may attempt violations.

Verified that assert_icp_limitations() as well as calls to it are compiled away in release build.

  • [x] The Jira issue number for this PR is: MDEV-______

Description

TODO: fill description here

Release Notes

TODO: What should the release notes say about this change? Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.

How can this PR be tested?

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended. Consult the documentation on "Writing good test cases".

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • [ ] This is a new feature and the PR is based against the latest MariaDB development branch.
  • [ ] This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [ ] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

spetrunia avatar Mar 13 '24 08:03 spetrunia