server icon indicating copy to clipboard operation
server copied to clipboard

🐛 Fixed configure for Xcode, CMake generate

Open saltpi opened this issue 1 year ago • 2 comments

  • [ ] The Jira issue number for this PR is: MDEV-______

Description

Execute command cmake . -G Xcode

with error information:

CMake Error in sql/CMakeLists.txt:
  The custom command generating

    /Volumes/Code/MariaDB/sql/yy_mariadb.yy

  is attached to multiple targets:

    gen_lex_token
    dist

  but none of these is a common dependency of the other(s).  This is not
  allowed by the Xcode "new build system".

How can this PR be tested?

Execute command cmake . -G Xcode

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • [ ] This is a new feature and the PR is based against the latest MariaDB development branch.
  • [ ] This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

saltpi avatar Feb 07 '24 06:02 saltpi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 07 '24 06:02 CLAassistant

I think it is a backwards dependency. nothing should depend on "dist". "dist" can depend on something else

vaintroub avatar Feb 07 '24 07:02 vaintroub